Am Dienstag, den 11.04.2006, 12:48 +0200 schrieb Jean-Marc Lasgouttes:

> Is there a reason why getTemplateFilters does not return a
> FileFiltersList?

I didn't want to #include "support/filefilterlist.h" from
ControlExternal.h (by introducing the FileFilterList type). This
argument lacks credibility if my #includes of insets/ExternalTemplate.h
and insets/insetexternal.h from within GExternal.h are considered;
therefore, I attach a patch that cures this flaw by moving them to
GExternal.C . Tell me if you'd prefer another way.

Bernhard


Index: src/frontends/gtk/GExternal.C
===================================================================
--- src/frontends/gtk/GExternal.C	(Revision 13708)
+++ src/frontends/gtk/GExternal.C	(Arbeitskopie)
@@ -25,6 +25,9 @@
 
 #include "ghelpers.h"
 
+#include "insets/ExternalTemplate.h"
+#include "insets/insetexternal.h"
+
 #include "support/lstrings.h"
 #include "support/convert.h"
 #include "support/filefilterlist.h"
Index: src/frontends/gtk/GExternal.h
===================================================================
--- src/frontends/gtk/GExternal.h	(Revision 13708)
+++ src/frontends/gtk/GExternal.h	(Arbeitskopie)
@@ -16,10 +16,7 @@
 
 #include "GtkLengthEntry.h"
 
-#include "insets/ExternalTemplate.h"
-#include "insets/insetexternal.h"
 
-
 namespace lyx {
 namespace frontend {
 

Reply via email to