Lars Gullik Bjønnes a écrit :
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes a écrit :
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | Lars Gullik Bjønnes a écrit :
| > | > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | > | [EMAIL PROTECTED] a écrit :
| > | > | > Author: larsbj
| > | > | > Date: Sun Apr 9 00:31:11 2006
| > | > | > New Revision: 13603
| > | > | > Log:
| > | > | > * filetools.[Ch]: Make functions that start with a capital
| > | > | > letter start with a lower letter.
| > | > | > * All other .C and .h in the cs: adjust for above change
| > | > | | I hope you didn't forget the qt4 frontend.
| > | > I certainly didn't forget, but I didn't really care about it either.
| > | | IMHO, if you introduce API changes that break the compilation,
| > you
| > | should care. I would have cleanup that for you if you asked.
| > Apart from a heads up, would it be different if you did this before
| > or
| > after the changes were committed?
| > Sorry for doing this without a heads up.
| > | > The availability of qt4 is not really high.
| > | | Well, I used it daily so I care. If you think this is not worth
| > it,
| > No, but qt4 is still so "rare" that we cannot expect all patches to
| > take it into account.
|
| My point is that you know what you are changing so changing that in
| qt4 would virtually take no time if you did it at the same time.
Since I have nothing even close to qt4 it would have taken quite some
time, and a lot of manual grepping.
sure, grep -r LibFileSearch frontend/qt4 take much more time than
compile & fix.
| It
| sure have taken a bit more time for Georg to look at what you have
| changed (it is not even in the log) and do the relevant change in
| qt4.
If he didnÃ't get compiler errors for all of them, thenI'd be really
surprised. (and a bug would have been found.)
| Besides, I am not sure qt4 is so rare compared with xform and gtk so
| your point is moot.
Ok, I'll bite... which distributions use qt4 as the default qt lib?
You don't need to have Qt4 installed to fix the calls sorry.
I am talking about actual developer testing running from time to time
the qt4 frontend. Again a problem of communication.