On Thu, 2006-03-30 at 16:23 +0200, Juergen Spitzmueller wrote:
> I think a good starting point, especially if your new on this area, is to use
> an existing dialog/controller, copy and adapt that. I think vspace could be a
> prototype in this case.
A couple of issues which it would be nice to rectify in new controller
code:
* Please supply all strings (translated) for the pulldown lists
(by the way, in GTK we call them comboboxes, I think Qt people
do too). Having these duplicated in the frontends is a bad
thing, and also leads to "magic numbers".
* Don't make me do a switch{} on which row is selected in a
combobox, and pass a certain value for certain values. Just let
me pass an integer, given that I've kept the options in the same
order that they were supplied to me. Equally, when I'm doing
update(), just give me an integer, don't make me do a switch{}
there too.
* Please don't depend on the length being zero or not passed -
just ignore it if "Custom" is not chosen, and please supply a
well defined length even if "Custom" is not chosen. I would
like to always read out of the length entry on apply(), and
always write into it on update(), without having to do any
conditionals about it.
John
