Enrico Forestieri <[EMAIL PROTECTED]> writes:
> Angus, I am a C++ newbie

Nooooo! Really? Wow! You don't come across as one!

> and don't even know if getline() is some sort
> of standard function

namespace std {
    template<class Elem, class Tr, class Alloc>
    basic_istream<Elem, Tr>&
        getline(basic_istream<Elem, Tr>& istr,
                basic_string<Elem, Tr, Alloc>& str);
}

> or a LyX support function ...
> > +               // Also, move the line1.empty() test to the place
> > +               // where you assign line1.
> 
> Really not, if I want to avoid an endless loop

:)

> Attached the revised patch.

Looks good to me. Since it fixes a crash, I'd get JMarc to shove it in the 1.4.x
tree. That means you'll need to enlist the help of someone thorough to test it 
:)

Angus

Reply via email to