On Thu, 2006-03-16 at 01:04 +0200, Martin Vermeer wrote: > On Thu, Mar 16, 2006 at 12:51:43AM +0200, Martin Vermeer wrote: > > ... > > > The reason for this is, that paragraph_pimpl.C expects something > > different from isTextInset than rowpainter.C. It expects to find out if > > the inset _actually contains_ a lyxtext with paragraphs. > > More precisely: it expects to find out if the inset contains "stuff" > that can be change track marked in LaTeX. Perhaps we should choose a > name that reflects this.
Even more precisely: the idea is, that if you have an inset that can contain internal text that can _itself_ be change-track marked in LaTeX/DVI, then in the text surrounding it, the change track markings have to end before it. So on the outside, the inset meta-character is handled as being of type Change::UNCHANGED. After the inset, external change track marking can then resume. This avoids the ugly (illegal?) situation that a character within a textinset would, for the purpose of LaTeX/DVI output, have two change tracking statuses: an external one for the whole inset, and an internal one for the character itself. Things like quote insets etc. which do not contain inner text, have isTextInset == false and will be change marked just like ordinary characters. I propose to change the name to containsInnerText() and the one to replace isTrueTextInset() could then be named isTextInsetBased() Does that sound like a plan? - Martin
signature.asc
Description: This is a digitally signed message part
