On Fri, Feb 24, 2006 at 02:21:04PM +0100, Georg Baum wrote:
> Jean-Marc Lasgouttes wrote:
> 
> >>>>>> "Georg" == Georg Baum
> >>>>>> <[EMAIL PROTECTED]>
> >>>>>> writes:
> > 
> > Georg> Jean-Marc Lasgouttes wrote:
> >>> So let's fix the crashes and release.
> > 
> > Georg> Yes please. BTW, what do you think of bug 2316? I am a bit
> > Georg> unsure if it should go in 1.4.0 or not. PRO: LyX can produce
> > Georg> invalid files without a fix. CON: It still needs testing, and I
> > Georg> don't want to delay a release at all.
> > 
> > You mean it can produce invalid LaTeX files, right?
> 
> No, AFAIK that is not possible since it has a hand crafted char by char
> latex output. I mean invalid .lyx files.
> 
> > A quick workaround 
> > would be the part of your patch that handles output of LyXFont when
> > language is latex_language. This is something that makes sense anyway.
> 
> That would actually not be enough, because the language can be set to
> something else without the other parts of the fix, and that other language
> would then be written.
> 
> > It seems to me from your discussions with Martin that the complete fix
> > is not very clear yet :)
> 
> I think it is clear now. A combination of Martins and my patches would fix
> all problems. What is missing now is the actual patch and testing.

I believe that, in your latest patch, simply moving the
text_.current_font etc.  stanza to doDispatch/default (as in my latest),
will produce a working and robust patch.

- Martin

Attachment: pgpDOtqllHQ36.pgp
Description: PGP signature

Reply via email to