Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| OK Lars,
|
| Why not going the other way? I can first provide a patch that will fix
| interface problems like for example the '++it' instead of 'it+1' but
| without touching ParagraphList.
| Then a second patch will introduce the new ParagraphList (the full
| dual vector/list one) that will provide the non efficient iterator
| interface that you want.
| Then a third patch that will fix the calls to the inefficient iterator
| interface.
|
| Would you be happy with that?
Not quite.
I really want he "Only move the vector inside ParagraphList and
provide the minimal necessary api" patch first. Why? Because I am not
sure that a combined vector/list is the best solution, perhaps
something else is the solution. Store shared pointers? Funky use of
map? vector with iterators list with Paragraph? To allow us to test
couple of different things I strongly believe we should do that first.
Also we should rename ParagraphList_fwd.h to ParagraphList.h and put
the implementation of ParagraphList in the corresponding .C file.
And with use of std::advance and boost::next we can 'create' and api
that when the right iterator etc. is provided the most effective
implementation is used. IMNSHO we should _not_ change the api to
something that is incompatible with what we have now.
--
Lgb
