John C. Spray wrote:
> So, which of the following statements is true:
> 1. Bibtopic is always enabled, and the checkbutton shouldn't be
> there
> 2. When bibtopic is enabled, the checkbutton should be disabled
This one. However, it does not really harm if we send
setOptions("bibtotoc"), since bibtopic disables the headings of the
bibliography completely. You are forced to use ordinary \section[*]'s
\subsection[*]'s etc. anyway.
Nonetheless the code ideally should be changed to
+ bool bibtopic = controller().usingBibtopic();
- if (bibtotoc && (!bibstyle.empty())) {
+ if (!bibtopic && bibtotoc && (!bibstyle.empty())) {
// both bibtotoc and style
controller().params().setOptions("bibtotoc," + bibstyle);
- } else if (bibtotoc) {
+ } else if (!bibtopic && bibtotoc) {
// bibtotoc and no style
controller().params().setOptions("bibtotoc");
} else {
// only style. An empty one is valid, because some
// documentclasses have an own \bibliographystyle{}
// command!
controller().params().setOptions(bibstyle);
}
Regards,
Jürgen
> 3. The checkbutton should always be enabled, and the backend is
> wrong to ignore us when we tell it that the user has activated
> it.
>
