Juergen Spitzmueller a écrit :
Abdelrazak Younes wrote:
There is already a side benefit to this new architecture: There are two
UI for branches, the one in the Document Settings and a simpler one.
Would it be a good idea to replace the latter by the former?
I don't think so. They serve different purposes (establishing/managing branch
types vs. inserting individual branch tokens).
OK. that was just an idea. IMHO, the "inserting individual branch"
functionality would be better served with a context menu (right-click).
Before converting the modules, I have a question (to Edwin Leuwen I
presume):
Most of the modules are connected to QDocumentDialog::change_adaptator
which calls QDialogView::changed() which is:
void QDialogView::changed()
{
if (updating_)
return;
bc().valid(isValid());
}
My question is: is this really necessary? Isn't that enough is we call
this when the "close" button or the "apply" button are pressed?
It is necessary since some dialog changes affect those buttons. I.e., if you
have senseless or incomplete information in the dialog, the OK and APPLY
buttons are disabled.
Ah... I suspected something like that. IMHO, this is a bit complicated:
the module says to the dialog which tells the controller which tells the
dialog that its button should be changed. I think I will define a signal
for that in the base class. The controller will then connect this signal
to the relevant buttons.
Jürgen
Thanks for commenting,
Abdel.
