This extra patch helped a lot:

Create document, select nondefault language, type some: OK!
Insert a table too and fill it OK!

Change language in normal text - it gets underlined as it should.

Change language for the paragraph containing a table:
first row gets underlined, which look odd. 
Probably nothing to do with your patch though. Individual
table cells do not change - they remain in the document language.
Do users have to change language for each cell individually?

Changing language for a single cell can be done, and the change will be 
written to the .lyx file.  BUT the display does not indicate the
language change - no blue underline, and nothing about language on the
status bar when the cursor visits such text.

Another issue that probably is unrelated to your patch:
Attempting to spellcheck some text in a different language
(select only that text) still tries to load the _document_ language
into aspell.  This fail when there is no dictionary for that language,
even though the language for the selected text exist.
This prevents spellchecking.


A remaining nit:
Insert an ERT box, minipage or a table into a document that has a 
nondefault doc language.
Observe how the curor is L-shaped (i.e. underlined) as if
the language is different (from document language) even though it isn't.
There will be no stupid underlining when actually typing text, but the
cursor indicate otherwise. Perhaps the same fix should be applied to cursor
handling as well?


Your patchset seems to address most of  the "language silliness" problems
now.  This is much better than what we had.  There is still the L-cursor,
and the missing underlining in table cells though.

Helge Hafting

Reply via email to