Sorry Jean-Marc, I have posted my previous mail before seeing your fix
to the "increase-depth" bug report.
Jean-Marc Lasgouttes a écrit :
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> I don't want to look presumptuous but, as far as I can
Abdelrazak> see, the only truly dynamic menu is the "Navigate" menu.
Abdelrazak> All the rest is static and it's easy to make an exception
Abdelrazak> for the "Open Recent" menu item. The "Navigate"
Abdelrazak> functionality can be put elsewhere (or made a special case
Abdelrazak> menu).
Removing functionality because it is a pain to implement is wrong. You
should argue from a UI point of view why you want to do this.
OK, UI wise, my opinion is that static menu-items should be separated
fron dynamically generated one. It's OK that a menu-item is grayed out
but it should not disappear because this is confusing. For example I
didn't know about this "Increase-depth" item before this bug report.
This should be always visible and grayed out if not useful in this context.
IOW, I don't want to remove functionalities, just move them to some
other place because I have the feeling that those are separated
functionalities.
Abdelrazak> I have the feeling then that this would simplify the
Abdelrazak> MenuBackend class a lot because all the items could be set
Abdelrazak> at the beginning and no need to redo everything each time
Abdelrazak> you click the Menubar.
What is the exact simplification you get by setting things at the beginning?
Here are some of the features of Menubackend:
[menu backe-end description]
I have to digest that before commenting further more :-)
Abdelrazak> IMHO, abstracting lyx action is enough.
We may discuss whether such or such feature is useful, but I am not
sure you can get rid of a proper model (in the MVC sense) of the menu
data. This is what menubackend does.
INHO, Qt4 propose an excellent model/view framework. I think this is the
way to go.
And I think that qt3 and qt4 will needs to be supported at the same
time for 1.5.
Abdelrazak> Agreed completely. And correct me if I'm wrong but it's OK
Abdelrazak> if one frontend doesn't use some GUII functionality, isn't
Abdelrazak> it? I think there are real benefits to this GUII stuff but
Abdelrazak> there is room for simplification.
I'd like to see the simplification first :) If you end up duplicating
lots of code for no reason, I do not see the point...
Rewriting does not mean duplicating ;-)
I have spent a lot of time already with this Qt4 port. And for now I
will just concentrate on that. I can't manage this port and the
simplification I was talking about at the same time... :-(
Abdelrazak> Please don't take this all personally, this is just an
Abdelrazak> opinion and I don't want to start a flame war. If you want
Abdelrazak> I'll just shut up now.
No problem, please don't shut up.
What we could try to do as a first step is see why your code crashes.
Rewriting a whole subsystem because of a crash is a bit extreme :)
Well I have sent you my code already. If you could take a look at how I
use the MenuBackend this would be fantastic.
Abdel.
JMarc
