>>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:

Georg> The tabular dialog is so broken that I fear we'd open a can of
Georg> worms if we touched it. 

Yes.

Georg> I have attached a patch that restores 1.3 behaviour. Once I
Georg> found out the reason for the crash (it was the recUndo call in
Georg> LyXText::setLayout), it was really easy.

I do not like much the new setLayoutWithoutUndo and would have
preferred an optional bool argument to setLayout or maybe even the
removal of the undo step from setLayout: I suspect that there are
other cases where we want to avoid undo (when we switch classes?) and
it is not difficult to do undo by hand.

Other than that the patch looks OK.

JMarc

Reply via email to