Am Dienstag, 1. November 2005 01:17 schrieb Michael Gerz: > Georg Baum wrote: > > >What do you mean with "gettext"? > > > > > The _method_ called gettext(...). (=> man -a gettext)
Thanks, I missed that one. > >I can't imagine that it fixes translation. The patch simply fixes a crash > >(which could also occcur on unix systems with improperly set up locale > >settings), and should be applied IMO. > > > > > This makes the difference (in unified diff format): > > @@ -136,7 +142,7 @@ > } > textdomain(PACKAGE); > const char* msg = gettext(m.c_str()); > - string translated(works ? msg : m); > + string translated(msg ? msg : m); > // Some english words have different translations, depending > // on context. In these cases the original string is > // augmented by context information (e.g. Now I see, the old version is obviously a copy and paste error. > IMHO, we could simply write: > > string translated(gettext(m.c_str()); > > because gettext shall never return null. In principle I agree, but since I can imagine that there are broken non-GNU gettext versions out there we may prefer the version in your patch. Georg
