On Wednesday, 26 Oct 2005 00:22 +0100, John Levon wrote: > Rather, we should do the > > #ifdef SP > #undef SP > #endif > > approach mentioned in the bug. That way, when nobody uses Solaris 9 or > earlier any more (it won't happen on S10), it's easy to remove the hack.
That is true. It won't affect any other platform/architecture than Solaris x86 then. I this case I would do something like /** * Solaris x86 hack * (Solaris x86 defines SP and PC in /usr/include/ia32/sys/reg.h) */ #if (defined(__i386) && defined(sun) && defined(__SVR4)) #undef SP #undef PC #endif (Note: It is __SVR4 in my example, not SVR4 as in the original patch, which does not work.) We use Solaris 8 on our Blastwave build-machines, by the way. This is to ensure that the packages we produce run on Solaris 8 and up. It's most likely going to stay like that till Sun announces the End-of-Life for Solaris 8. -Markus
