Am Mittwoch, 5. Oktober 2005 18:06 schrieb Jean-Marc Lasgouttes:
> >>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
> 
> Georg> It looks like the attached, then. The asserts (if we add any)
> Georg> belong in MathNestInset::cell, MathGridInset::col and
> Georg> MathGridInset::row, because bad indices would harm there. 
> 
> I do not really see why the asserts in MathGridInset are necessary.

If it is possible that a cell index is out of range then it will harm 
there too. IMHO it does not make sense to catch it only in the other 
methods.

> Georg> I am not sure if we really need the asserts: MathMacroInset is
> Georg> really special. Apart from that I believe that the
> Georg> cell/column/row handling code is very robust in general. The
> Georg> asserts are now in a central place that gets called a lot.
> Georg> Shall I commit with or without the asserts?
> 
> Do as you prefer. It might be indeed that they are not needed.

OK, I left them out.


Georg

Reply via email to