>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> The attached patch moves win32-specific code out of package.C Angus> and into os_win32.[Ch]. It will also allow said code to run of Angus> older versions of Windows when compiled with the preprocessor Angus> macros WANT_GETLONGPATHNAME_WRAPPER and Angus> WANT_GETFILEATTRIBUTESEX_WRAPPER defined. We haven't got there Angus> yet. What about #defin'ing WANT_foo_WRAPPER unconditionally when NewAPI.h is available? This would avoid the requirement of distributing this header. Something like: #ifdef HAVE_NEWAPIS_H # define WANT_GETLONGPATHNAME_WRAPPER # define WANT_GETFILEATTRIBUTESEX_WRAPPER # define COMPILE_NEWAPIS_STUBS # include <NewAPIs.h> # undef COMPILE_NEWAPIS_STUBS #endif I am not in favor of adding yet another configure option. A check for NewAPIs.h in configure should be enough. Angus> OK to apply? Otherwise the patch is fine. Angus> Jean-Marc, do you want the equivalent for LyX 1.3.x? Strictly Angus> speaking, it's unlikely that Win95/Win98 users will ever get Angus> LyX 1.3.x running because Qt/WinFree will fall over for them. Angus> However, we need parts of the patch anyway to allow LyX to run Angus> on Win2000 which Qt/WinFree will run on. I am not against it, if only for homogeneity (if it is not too much work for you). You decide. JMarc
