Jean-Marc Lasgouttes wrote: > Angus> Moreover, the attached patch should allow the code to be > Angus> compiled on Cygwin as well as on MinGW. > > Angus, > > Although I noted you did not ask me for my opinion, I'll give it > anyway :)
Well, I comment on Martin's patches to parts of the code base that I don't understand, so I'm happy to see others giving their opinions freely too :) > Would it be possible to move the GetFolderPath code to os_win32.C? It > could be exported via a simple get_folder_path(int) function, or > something. I understand there is a problem with declaring it in os.h, > though. and therein lies the crux of the problem. Of course it is possible to do this, but does it make any sense to do so? Only code within a USE_WINDOWS_PACKAGING define would call get_folder_path and the int that is passed to the function has meaning only under Windows. Why make the function available to other environments, even if it returns only std::string()? Note that lots of code within package.C is protected by "#ifdef (USE_XXX_PACKAGING)" and that there's absolutely no pollution of the code base when compiling on Mac or on a POSIX box. Perhaps you'd prefer a separate os_win32.h that is explictly #included by package.C ? -- Angus
