On Fri, 2005-09-23 at 13:56 +0100, Angus Leeming wrote: > Martin Vermeer wrote: > >> Attached are edited highlights from this profiling. There would > >> appear to be lots of scope for improvement :) > >> > >> Assuming that I'm editing the right bit of the profile log of > >> course... > > > I think it is. And it is precisely the things my patch addresses... > > BufferView-pimpl-update, lyxtext-redoParagraph, screen-redraw and > > all that stuff. > > Linking here takes over an hour with Debian unstable's gcc 4.0.2, ld > 2.16, so I'm not really in a position to do too much experimentation. > However, there's no reason why you couldn't generate a similar > profiling executable using the configure command that I posted. > Presumably, linking times for you will be much shorter if you're > using gcc < 4. > > Given Helge's reports on improved behaviour with your patch, I'd > anticipate that it, or something like it, will go into the tree soon. > Thereafter, I'll generate a new executable and post a new report if > nobody beats me to it. > > > Except > > QContentPane::keyeventTimeout() > > which we should still look at separately then: > > // Restart the timer. > > step_timer_.start(25, true); > > If this is the timer in milliseconds, perhaps we should see what > > happens if we raise it to 50. > > int QTimer::start ( int msec, bool sshot = FALSE ) > > Starts the timer with a msec milliseconds timeout, and returns the ID > of the timer, or zero when starting the timer failed. > > If sshot is TRUE, the timer will be activated only once; otherwise it > will continue until it is stopped. > > Any pending timer will be stopped.
connect(&step_timer_, SIGNAL(timeout()), SLOT(keyeventTimeout())); So when it times out, it is restarted... as it says in the comment. The idea behind this was at the time, that there would never be more than one "unserviced" timer running even during congestion, as would happen with a repeat timer. > Anyway, "cvs annotate" is blaming you for this code :) > > 1.35 (vermeer 06-Jun-05): > 1.35 (vermeer 06-Jun-05): // Start the timer, one-shot. > 1.35 (vermeer 06-Jun-05): step_timer_.start(25, true); > > Diff to previous 1.34 > Lars's key input queue Yes... he tricked me into that :) - Martin
signature.asc
Description: This is a digitally signed message part
