On Sep 19, 2005, at 8:40 AM, Jean-Marc Lasgouttes wrote:

"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:


Bennett> This mostly works, but there are a few anomalies. Selecting
Bennett> File > Open brings down the open file sheet from the main
Bennett> document window (as it should), however:
[...]
Bennett> I don't remember these options being enabled with Jean-Marc's
Bennett> patch, but I'm not sure they were disabled either. (Should I
Bennett> bother recompiling?)

I think the problems you describe already existed before our recent
patches.

I've checked: yes, they did.

This may mean that we are never going to be able to have
menus work when a dialog is active, and that we should just use the
default Qt empty menu in this case. Basically, I can do what you
prefer depending on OS X users feedback.

I fear however that the code to disable some entries when a dialog has
focus is too clever and does not work very well. I tend to think we
should just remove this code.

I would frankly prefer to keep the code and the remote chance that someone will try selecting TeX Information from the menu when a file open dialog is present. Two reasons:

1. As I said when I urged Jean-Marc to write this code initially, having menus disappear is very disconcerting for Mac users. Yes, we can get used to it, but the initial impression of an application that behaves like this is that it must not be well written, and I fear that would turn away potential new users. (That's in line with some feedback I've received about LyX/Mac-1.3.x concerning open/save dialogs: they're not Mac standards, so the program must not be very good.)

2. Even when a user selects TeX Information when a file open dialog is present and then has to force quit LyX, unsaved changes to documents are retained in the emergency save file. So the worst case is that the user must restart LyX and then keep working. Given the unlikelihood of users trying this, the negative side effects seem quite minimal.

That's my two cents.

Bennett

Reply via email to