>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Jean-Marc, the attached patch enables LyX 1.3.x to at least Angus> fire up under Win98. Whether the resulting executable is any Angus> use is a separate issue, as mentioned here: Angus> http://wiki.lyx.org/Windows/LyX136experimental#win98 Angus> The patch does three things: 1. Ensures that various char Angus> arrays have max size of PATH_MAX. Early versions of Windows Angus> require it for some system functions. I am not sure I understand: you make the array shorter, but you do not decrease the PATH_MAX parameter givent to the functions. How is this supposed to matter? Angus> 2. Pass file names input from "outside" through Angus> GetLongPathName. This fixes the problem with 8.3 file names Angus> reported by Sven Schreiber. (See Squashed LyX Bugs on the same Angus> web page.) What about moving this GetLongPathName code inside os_win32::internal_path? It would be _much_ better than cluttering the source, and it seems to me that it fits the semantics of the function. Angus> 3. Loads up shfolder.dll dynamically. It transpires that whilst Angus> SHGetFolderPathA can be accessed from shell32.dll on Win2K and Angus> newer machines, Microsoft recommend that the portable way to Angus> access the function is through shfolder.dll. Would using SHGetSpecialFolderPath be enough? It works out of the box with win98. http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/platform/shell/reference/functions/shgetspecialfolderpath.asp Angus> I'm unsure which route we should go down on this one; do we Angus> need this dynamic link stuff or should we ensure that we link Angus> against shfolder.dll at link time? The dynamic link stuff seems a bit complicated to me, but if we have to... JMarc
