Lars Gullik Bjønnes wrote:
> "path" descriptive? You got to be joking :-)
> If it were a string it would be ok.
>
> withPath, withFullPath, fullPath, absPath, addPath
>
> ... perhaps addFullPath? or just addPath.
ok ok.
> >> This looks a bit dangerous. You are deleting iterators from the vector
> >> while at the same time iterating over it.
> |
> | OK, I think this one is better:
> |
> | for (; it != end; ++it) {
> | *it = regex.Merge((*it), "/");
> | }
> | list.erase(std::remove(list.begin(), list.end(), ""), list.end());
> |
> | (cf. attached patch)
>
> Yes, a lot safer. One thing though... why are there empty elements in
> the list to begin with?
The vector is being generated from the files with getVectorFromString, using
"\n" as a separator. The empty item comes from the last (empty) line in the
files.
> | Are you happy with the updated patch?
>
> I'll have a look
Thanks.
Jürgen
