Jose' Matos wrote:
> My proposed patch follows attached as well.

If '\end_preamble' should always be present can I suggest changing the
warning to something reassuring?

     j = find_token(file.header, '\\end_preamble', i)
     if j == -1:
-        file.warning("Malformed LyX file: Missing '\\end_preamble'.")
-        return
+        file.warning("Malformed LyX file: Missing '\\end_preamble'
\nAdding it now and hoping for the best.")
+        file.header.append('\\end_preamble')

> This is a superficial fix, I let to those who know better than me to
> decide what to do with the patch.

If it means that you can now convert a file that would otherwise fail, then
I'd say that you should commit the patch ASAP.

-- 
Angus

Reply via email to