>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Jean-Marc Lasgouttes wrote: - os << "\\viewer \"" << Angus> cit->name() << "\" \"" - << cit->viewer() << "\"\n"; + os << Angus> "\\viewer \\\"" << cit->name() << "\\\" \"" + << cit->viewer() Angus> << "\\\"\n"; >> This seems very strange to me. Shouldn't it be: >> >> + os << "\\viewer \\\"" << cit->name() << "\" \"" + << >> subst(cit->viewer(), "\"", "\\\"") << "\"\n"; Angus> Maybe. Would '\' directory separators need to be escaped too? Angus> ... A quick read of lyxlex_pimpl.C says "yes". Yes, you're right. >> I understand this can make you nervous, but we do have a problem >> with double quotes in command names. Angus> This would handle "-quotes in \viewer commands. If we go this Angus> route we'll need something similar for \converter commands too, Angus> no? Yes. A helper function would be welcome. Angus> Would that require changes to lib/configure? I do not think so, we do not produce these quotes ourselves. JMarc
