Angus Leeming wrote:
> This isn't the right way to internationalise this, is it? The right way is
> something like:
> text += boost::format(_("Change by %s\n\n"), author);
OK, I'll commit the attached, if you feel comfortable with it.
(Only the actual date is still untranslated)
Jürgen
Index: QChanges.C
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/qt2/QChanges.C,v
retrieving revision 1.13
diff -u -r1.13 QChanges.C
--- QChanges.C 1 Jul 2005 17:19:42 -0000 1.13
+++ QChanges.C 4 Jul 2005 11:38:08 -0000
@@ -15,11 +15,14 @@
#include "Qt2BC.h"
#include "qt_helpers.h"
+#include "support/lstrings.h"
+
#include "controllers/ControlChanges.h"
#include <qpushbutton.h>
#include <qtextview.h>
+using lyx::support::bformat;
using std::string;
@@ -60,9 +63,9 @@
string date(controller().getChangeDate());
if (!author.empty())
- text += _("Change by ") + author + "\n\n";
+ text += bformat(_("Change by %1$s\n\n"), author);
if (!date.empty())
- text += _("Change made at ") + date + "\n";
+ text += bformat(_("Change made at %1$s\n"), date);
dialog_->changeTV->setText(toqstr(text));
}
