Uwe Stöhr wrote:
Angus Leeming wrote:
To be honest, I haven't tried it since the original proposal. I don't think that our views are wildly different though, so there's hope ;-)

I added a summary page at the beginning as you want it. So please give it a try and PLEASE report me if acroread was found (I need feedback if the pdf stuff is now correct). The actual version is here:

OK.

I changed the filenames as you wnated and tried to make my script as similar to the lasest CVS version. The diff is attached and at my script webpage.

Good man!

Btw. please don't deform my code as you for example did in lyx_utils.nsh. I don't like meaningless variable names like "$0" as it makes it difficult for me, others and yourself (e.g. if you haven't had a look at the code for half a year).

Shrug. Your code caused the compiler to emit a couple of warnings, so I silenced it. One way of achieving transparency is:

!macro FooBarBody Var1 Var2 Var3
 ; insert code to use Var1 Var2 Var3 here
!macroend

Function FooBar
  Exch $0
  Exch
  Exch $1
  Exch 2
  Exch $2

  !insertmacro FooBarBody $0 S1 S2

  Exch $2
  Exch
  Exch $1
  Exch 2
  Exch $0
!FunctionEnd

But basically, NSIS is a language to hide meaning, not make your intent clear :-(

NOTE I updated the languages files as follows:

- The Program description doesn't contain the webadress as this is unneccesary (we have the download option for this) and often leads to very long strings (they are then cutted in the installer which looks ugly).

- I translated the latest error string "CreateCmdFilesFailed" in german.nsh

- I changed the summary description "SummaryPathPrefix" in english.nsh and german.nsh to make it clearer as not everybody knows what to do with an information about lyxrc.default.

NOTE My installer version supports also the swedish language, please also add this to your version too.

??? How peculiar. I thought it already had it... Yes, it does.

Then, the only remaining difference is how we deal with MinSYS,Python,Perl, right?

Yup. But as understand it you also don't like the way of my font installation.

No, I think that your font stuff is excellent.

I mean the first impression of a program is important, not too much but enough to be not decided by only two persons.

Agreed. but having two development trees is just confusing us both. Let's merge it all into a single set of sources and move forward.

Also my opinion. The problem was that I changed too much in a relative short time ;-)

:-)

Consistency. (Yes, I'm a PITA sometimes ;-))
Hä? What is a PITA?

Pain In The Ass; Schmerz im Arsch.

Peter Kümmel wrote:

 >> Then, the only remaining difference is how we deal with
 >> MinSYS,Python,Perl, right?
 >
 > You could provide both ways and give the user the choice.
 > Attached a shot from the Firefox setup.

I also prefer this option. Angus' version could be the one for advanced users and my for average user.
Angus, is this an option also for you?

I'm going to post a minimal, does nothing, installer to show you what I think we should have.

Angus

Reply via email to