Georg Baum <[EMAIL PROTECTED]> writes:

| Lars Gullik Bjønnes wrote:
>
>> Georg Baum <[EMAIL PROTECTED]>
>> writes:
>> 
>> | -           transform[string(entry.lyxname)] = int(entry.lcolor);
>> | +           LyXTransform[string(entry.lyxname)] = int(entry.lcolor);
>> | +           LaTeXTransform[string(entry.latexname)] = int(entry.lcolor);
>> 
>> Can you please change the names of these variables.
>
| Would lyxcolors and latexcolors be OK? Please make a suggestion if not,
| because I don't really know what you want.
>

especially the uppercase is not good.

your suggestion would be ok.

>> is the "string()" cast really needed?
>
| OK, I removed lots of casts. Would the attached be OK?
| BTW, I also tried the multi_index variant because I was curious. The idea
| seems nice, but too much code IMHO (or I missed something).

Probably not.

-- 
        Lgb

Reply via email to