On Fri, Apr 29, 2005 at 06:52:17PM +0200, Georg Baum wrote:
> Martin Vermeer wrote:
> 
> > +        case LFUN_INSERT_MATH: {
> > +                bool const textarg = 
> > +                        arg == "\\textbf"   || arg == "\\textsf" ||
> > +                        arg == "\\textrm"   || arg == "\\textmd" ||
> > +                        arg == "\\textit"   || arg == "\\textsc" ||
> > +                        arg == "\\textsl"   || arg == "\\textup" ||
> > +                        arg == "\\texttt"   || arg == "\\textbb" ||
> > +                        arg == "\\textnormal";
> > +                flag.enabled(currentMode() == MATH_MODE && !textarg
> > +                        ||   currentMode() == TEXT_MODE && textarg);
> 
> I think this should be
> 
> +                flag.enabled((currentMode() == MATH_MODE && !textarg)
> +                        ||   (currentMode() == TEXT_MODE && textarg));
 
OK.
 
> > +                break;
> > +        }
> > +        case LFUN_INSERT_MATRIX:
> > +                flag.enabled(currentMode() == MATH_MODE);
> > +                break;
> > +        case LFUN_MATH_MODE:
> > +                // i.e., "math-mode on" gets through in text mode
> > +                flag.enabled(currentMode() == MATH_MODE || !arg.empty());
> 
> What does this do?

Removed.

> Apart from this and the .ui file change 

Removed too.

> this looks entirely reasonable to
> me: big improvement with little changes.

Committed. 

- Martin
 

Attachment: pgpyV3cCntAGH.pgp
Description: PGP signature

Reply via email to