Jean-Marc Lasgouttes wrote: > Angus> One thing I noticed after I had posted my patch last night is > Angus> that there's a change of semantic here (ControlSpellchecker.C). > Angus> At the moment, the lyxrc variables are used to fall through to > Angus> Ispell at run time. With the new configure stuff, they'll fall > Angus> through to SpellBase. > > I just noticed this variable :) I really can't read. > > Angus> So, that leads to two questions. 1. Should the check for > Angus> USE_ISPELL be dependent on USE_[AP]SPELL? > > Yes. It is just a matter of removing a few else's. > > I guess the variable can still be useful.
Ok, the attached version of the patch removes [ap]spell.m4, moving all the spelling stuff into a new spell.m4 with a LYX_CHECK_SPELL_ENGINES function. I found that I needed to initialise lyx_use_pspell=false before going on to test for pspell's presence or src/Makefile would always try and build pspell.C. I can confirm that the only additional change needed to get the LyX 1.4.x sources to compile with mingw is this in lyx_cb.C #ifdef _WIN32 # define fork() -1 #endif A kludge, but an obvious kludge and I really don't think we want to introduce multiple threads before 1.4 is released. > Angus> * The ability to launch the spell checker dialog (setStatus?) > Angus> should be dependent on one of USE_[API]SPELL being defined. > Yes. > > Angus> Maybe we could make compilation of ControlSpellcheker.C and > Angus> associated frontend views dependent on this as well, although > Angus> that is probably overkill. > I think it is overkill for now. > > Angus> * The [aspell,ispell,hspell] combox in the preferences dialog > Angus> should be activated only if USE_ISPELL is defined. > Yes. I'll deal with these points later. Personally, I'm of the opinion that this patch is now ready to be committed to the cvs repository. Do you agree? I won't do so, however, until Monday or Tuesday next week. I take it you'd like me to port this patch to the 1.3.x branch also? Have a good w/e. -- Angus
configure.diff.gz
Description: GNU Zip compressed data
