Helge Hafting wrote: > > As reported before, there is still a (qt only) problem with the longtable > > ui: the "is empty" checkbox cannot be disabled once it is checked. > > Judging from the xforms code I believe that some of the lfun handling in > > the qt tabular dialog is completely wrong. I think the attached patch is > > correct. > > I tested it, and now I could uncheck every box in the longtable dialog.
Yes, and actually, it also does what it has to do (deactivate the features). In the meatime, I have also checked 1.3, and noticed that the qt ui is the same mess there, so the code was wrong from day 1. Even if you can uncheck "is empty" there, it is not unsetted and therefor checked again if you reopen the dialog (this difference is due to the bug below). Also, unchecking "double" (border) unchecks "status", too (as I expected from the wrong lfuns). I am wondering if anybody ever used those features (also, the ui is really counter-intuitive). To me it's now clear that the patch is correct. Can I apply it? > > Apart from that, there is still a weird problem: in (some of?) the qt > > dialogs (tabular, box at least), the disabled widgets are not greyed out > > when the dialog has been reopened. One action inside the dialog is > > needed. You can reproduce this e.g. with the longtable checkboxes, but > > also with the valign combo in the box dialog. Maybe also the "flickering" > > when you are toggling the longtabular checkboxes is related. I have no > > clue what's going on (it's not a problem of the dialog code itself). > > I noticed this. Only cosmetic :-) Yes, but it's a regression. And I'd really like to know the reason. Thanks for testing. Jürgen
