Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
>
>>> I cannot do much to make sure that the new win32 code works, so
>>> I'll have to trust you on this :)
>
| Angus> No, all you have to do is convince yourself that it doesn't
| Angus> break on *nix. We've never supported win32 before so we can't
| Angus> regress :)
>
| Fair enough.
>
>>> Why do you use #if defined(_WIN32) instead of #ifdef _WIN32 like
>>> everywhere else?
>>>
>>> (this kind of useless remark is further proof that I do not have
>>> any real problem with the patch!)
>
| Angus> I just find it easier to read. Especially when there're a
| Angus> couple of parts to the test.
>
| OK, it seems that our Code_Rules do not say anything about that...
I am in favour of the "#if defined(FOO)" style.
--
Lgb
