Re: [Patch] Fix for bug 1792 (cursor up stuck in math)

[Martin Vermeer]

On Thu, Mar 10, 2005 at 07:40:11PM +0100, Juergen Spitzmueller wrote:
> Martin Vermeer wrote:
> > +       if (row.pos() < end && c >= end
> > +           && par.isInset(end) && par.getInset(end)->display()) {
> > +               c = end - 1;
> > +       }
> > +
> 
> This change has introduced a new bug.
> - Insert a Note inset
> - Collapse
> - Uncollapse
> 
> Assertion triggered in char Paragraph::getChar(int) const by failing check 
> "pos< int(text_.size())" in file paragraph.h:293
> 
> The assert does not happen if I comment out the above.
> 
> Regards,
> Jürgen

Are you sure this bug report is accurate?

I find that inserting a note and doing anything with it does nothing to
crash lyx... but clicking on an end of paragraph gives precisely the
above assert.

Try the following change (works for me):

-       if (row.pos() < end && c >= end 
+       if (row.pos() < end && c >= end && end < par.size()

Funny, after I committed the patch, I vaguely suspected that something like 
this could happen, but neglected to follow up.

Please test.

- Martin

pgplaxXY6VS94.pgp
Description: PGP signature