Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>>>>>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
>
| Lars> Not a patch with the last fix as well.
>
| Lars> Unless I get objections this is going in.
>
| I am not sure that mixing $(PCH_SOURCE), ./pch.h and $(srcdir)/pch.h
| (which should be $(PCH_SOURCE) btw) improves readability. Also, I do
| not think the explicit "./" is helpful (not typical Makefile style).
I think some variables now inside the PCH def must be moved outside.
For the EXTRA_DIST and the BUILT_SOURCES variables in .am's.
| Typically, a line like
| $(PCH_FILE): $(PCH_SOURCE)
>
| should be
| $(PCH_FILE): pch.h
| to let VPATH do its job.
>
| I do not mean that this will improve the way the patch works, it is
| just stylistic.
I have not decided what to do with this. So I'll leave it as is for
the time being.
Ad. the ./, I had some problems at the beginning when I set up the
pch support, this was fixed by adding ./. Very likely this has no
impact now.
--
Lgb
