Am 26.02.2005 um 21:11 schrieb Bennett Helm:
I've taken Andreas' patch and deleted the code pertaining to lyx_main.C and applied it along with Angus' changes above to lyxrc.C. It works well.
A few suggestions.
First, my fig2dev is located at /usr/X11R6/bin, and my groff, lp, and lpr are located at /usr/bin. So I would add these two to the ac_pathprefix_candidates list. (Also, delete the final "/" from "/usr/local/teTeX/bin/powerpc-apple-darwin-current/" in that list!)
/usr/bin is NOT in your std path ??? How do you run sed & grep?
Second, as things stand if I set path_prefix to some directory (such as "test/dir", and then run reconfigure, the current code *overwrites* my path_prefix with ones it deems necessary; this is true even if the directory I enter is a directory where some needed files are located but which aren't in the ac_pathprefix_candidates list (such as "/usr/bin"). The code instead ought to *add* new paths to the end of path_prefix.
It shouldn't behave like that. The directory you enter should overwrite the path which
is found by reconfigure. With Angus' changes the system path_prefix will appear again
if you delete the path_prefix, save preferences and restart LyX. Any non-empty path_prefix
will stick.
Finally, currently any change to path_prefix via the preferences dialog doesn't make any difference until LyX is restarted. This is not true of the other paths that can be set via that dialog, and I think it's liable to cause confusion. Can we add either a note in the dialog itself saying this or a new dialog that pops up, as with reconfiguring?
I checked the code for Reconfigure and it doesn't feel right. It creates a new lyxrc.defaults
file and overwrites the runtime settings with these values; but doesn't save them to the
users preferences file (which I don't want, but the way it is the current preferences are different
to the saved preferences).
Shouldn't Reconfigure() apply the users preferences after reading the lyxrc.defaults
file? This is the way it is done when LyX starts.
I don't think we need to merge the system and the user version of the path_prefix. If users
provides their own path_prefix they will have to adjust it manually after a reconfigure
(Should be documented, though)
The activation of the new path_prefix directly after a reconfigure should be possible, see actOnUpdatedPrefs() in lyxfunc.C.
Is the "restart to make use of new textclasses" alert still necessary?
/Andreas
