Angus Leeming <[EMAIL PROTECTED]> writes:

| Tracking down the reasons for Bennett's problems with LyX compiled
| with gcc 2.95 on MacOSX, I got pissed off and changed the names of the
| setter and getter functions. This patch
>
| * renames GetEnv as getEnv
| * renames putEnv as setEnv. It also changes the function signature from a
| single coded argument "name=value" to a pair of arguments (name and
| value). The encoding is performed withing setEnv only if ::putenv is
| called. Thus users of ::setenv don't pay for an unnecessary
| coding/decoding step. FWIW, it was this change in the argument list that
| lead to the change in the function name.
>
| It also stops compilation in setEnv if neither HAVE_SETENV nor HAVE_PUTENV
| are defined. At the moment we return a "failed" value at run time which
| doesn't really provide much motivation to find the appropriate function on
| such a system.
>
| It seems like an intelligent change to make to me, but I see that Lars' has
| said that we should be thinking in terms of a freeze. Can I ask formally,
| therefore, for permission to commit this patch.

Patch ok.

-- 
        Lgb

Reply via email to