Jose' Matos wrote:
> This patch fixes bug 1816.
> 
> I don't understand why the pextra_widthp argument goes in a separate
> line, but if it happens then this patch takes that into account.
> 
> The patch seems clean, and safe, so I will apply it it. Any objection?

No objection, but a couple of suggestions.

It might make sense to protect the regex with a '^', meaning "if the line 
starts with "\\pextra_width" ?

+pextra_widthp = re.compile(r"^\s*\\pextra_widthp\s+\S*")

Also, don't you want to guarantee that the length itself exists?
'\S*' will match any number of non-whitespace characters (including none 
at all).

-- 
Angus

Reply via email to