Andreas Vox wrote: > I thought about that. I changed the methods in Exporter to create non- > existing directories (I thought first about your advice to add an > "addExternalDirectory" method, but when I looked at the code this > looked simpler).
It is simpler indeed. But "addExternalDirectory" ensures that a directory is only created when it is wanted. Remember, the input to addExternalFile() may come from external templates (user input!), and a typo there should result in an error message but not mysteriously new directories. Your method is IMHO too much "black magic". > - Can I have "mkdir -p" functionality with createDirectory? It is not necessary IMO, because the parent exists already. Or do you want to allow arbitrary directories? We should not do this IMHO unles we also allow the main file to be placed in arbitrary locations. Otherwise this will be confusing. > - Does the '$$n' substitution need special protection? (the string > containing > the '$$n' will be hardcoded in mathhullinset.C) I don't think so, but as I wrote above it should not be used. > - I copied the Alert message verbatim from another place. What do I have > to do if I introduce new internationalized strings? Any suggestions for > a better error message? Simply enclose the string with _(). It will appear in the po files the next time they are updated. If it is a static string you have to do some tricks with _N() IIRC. Georg
