Asger Ottar Alstrup wrote: > Angus Leeming wrote: >> I sent you the patch that was needed to compile LyX 1.3.x with MinGW. >> Your patch contains vast changes to FileInfo.C, no? Mine does not. Yet >> appart from the change of lyx::Assert to BOOST_ASSERT, the only change >> to the file is to the namespace. >> >> Good enough for you? > > No. You do not get my point: > > The changes I propose are supposed to be universally usable on Windows, > with both MSVC, mingw and cygwin. > > On the other hand, your patch does not work for MSVC. > > Therefore, my approach is better than yours.
Ok, I did misunderstand you. Having said that, I disagree with your conclusions. Your patch cripples FileInfo. Agree? The code in FileInfo.C works perfectly well under MinGW, so your proposed changes to FileInfo.C AS THEY STAND are going to be a step backward on MinGW. I emphasise the AS THEY STAND because I found that I had to make similar changes to you to make the symbolic link stuff compile under MinGW. But JMarc suggested that I see where this symbolic link stuff was actually used. It turned out to be in the XForms File dialog only and only in a piece of uselessness that attempts to reproduce the output of "ls -l" for a file. The agreed approach was simply to strip this code out of the XForms file dialog and therefore also from FileInfo.C. See http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/support/FileInfo.C Revisions 1.25, 1.26 and 1.27 I'm suggesting to you that the BEST approach may well be to get rid of some of the functions themselves. -- Angus
