Asger Ottar Alstrup <[EMAIL PROTECTED]> writes:

| Hi,
>
| The attached patch to dociterator.C should be obviously correct. You
| can not access a textRow if there are none. If you apply this, you
| will also get an assertion failure in text.C breakParagraph as I do
| without even this patch, because MSVC is so kind to flag a memory
| access error due to poisoning.
>
| So, to avoid that assertion, I simply add a check before we ask for
| the textRow at that place in the code. See the patch to text.C. That
| fixes the crash, and break works for me now. Maybe the fix is not the
| best, but it is a monotoneous improvement: At least it does not crash
| anymore. (To reproduce the bug, start a new document, write something
| and press Return.)
>
| In addition, I also attach a patch to paragraph.C to find more of
| these problems.
>
| Well, I meant to include a patch to text.C, but it has been trying to
| make a diff for half an hour without any success. I just attach the
| latest version instead. You can make your own diff.

So this isn't the case of a missing initialization of rows_?

Shouldn't a paragraph _always_ have at least one row if it exists?

Could be that I don't understand this, but I am afraid that this just
hides the real bug.

But sure, the asserts are good.

(This is a carte blanc to everyone: if you see a place where there is
something we can assert on, then just put an assert there. Patch to
list first as usual of course.)

-- 
        Lgb

Reply via email to