Your reworking has completely broken LyX on cygwin for me.
I can no longer run any external programs.
Even running Tools->Reconfigure comes back immediately with no effect.
Help!
---Kayvan
On Mon, Jan 17, 2005 at 12:05:06PM +0000, Angus Leeming wrote:
> Angus Leeming wrote:
>
> > Kayvan A. Sylvan wrote:
> >> I am able to run it from the build directory via "src/lyx". and was
> >> able to confirm that the patch works as expected. Thank you!
> >
> > Good. Then I'll commit that.
> >
> >> Now, we have to fix this new bug (can not determine the path to the
> >> LyX binary).
> >
> > Hmmmm. So "lyx" is in your path, right? Can you investigate? The routine
> > that is failing is src/support/package.C.in's abs_path_from_binary_name
> > (get_binary_path, actually).
>
> Kayvan, I just committed a little patch to this piece of code. It fixes a
> clear bug but I wonder if it resolves your problem too?
>
> @@ -388,11 +391,10 @@ string const get_binary_path(string cons
> std::vector<string>::const_iterator it = path.begin();
> std::vector<string>::const_iterator const end = path.end();
> for (; it != end; ++it) {
> - if (!os::is_absolute_path(*it))
> - // Someone is playing silly buggers.
> - continue;
> -
> - string const exe_path = AddName(*it, exe_name);
>
> + // This will do nothing if *it is already absolute.
> + string const exe_dir = MakeAbsPath(*it);
> +
> + string const exe_path = AddName(exe_dir, exe_name);
> if (FileInfo(exe_path, true).isOK())
> return exe_path;
> }
>
> --
> Angus
--
Kayvan A. Sylvan | Proud husband of | Father to my kids:
Sylvan Associates, Inc. | Laura Isabella Sylvan | Katherine Yelena (8/8/89)
http://sylvan.com/~kayvan | "crown of her husband" | Robin Gregory (2/28/92)
