>>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:

Georg> Updated patch that addresses the empty argument problem
Georg> attached. I created two new methods Parser::getFullArg and
Georg> Parser::getFullOpt that handle empty arguments correctly, since
Georg> this was also used in getCiteArguments(). Actually this lead to
Georg> cleaner code in getCiteArguments(). It is tested and works, the
Georg> only thing that I don't like are the names getFullArg and
Georg> getFullOpt. Do you have a better idea? Otherwise this is going
Georg> in as-is.

It looks better IMO. What I would do maybe is to change Parser::Arg to
a small class with a few accessors that allow to get the equivalent of
getFullArg and getFullOpt. So the code using this would manipulate
Parser::Arg objects instead of strings. I think this would lead to
simpler code, but all the details are not clear in my mind.

But we can do that later if you prefer.

JMarc

Reply via email to