Lars Gullik Bjønnes wrote:
> What were the hard arguments against this patch?

You should #include <boost/format.hpp> in lstrings.h, protected by the
I_AM_NOT_AFARID_OF_HEADER_LIBRARIES macro of course.

However, I'd just get rid of I_AM_NOT_AFARID_OF_HEADER_LIBRARIES. The whole
world is pulled in by Boost and we don't suffer too badly as a result.

If you are going to keep it, then at least spell it correctly. AFRAID, not
AFARID.

If you're going to go to the effort of renaming 'tostr' to 'convert', then
I don't think you should retain tostr.h. Give it a new, more
representative, name.

-- 
Angus

Reply via email to