Angus Leeming wrote: > Alfredo Braunstein wrote: > >> This patch gets rid of Paragraph::forceDefaultParagraphs (the second user >> of Paragraph::inInset) >> >> The replacement is to call InsetBase::forceDefaultParagraph when the >> inset is available, add to add an aditional flag to OutputParams to be >> passed down in latex() methods, when the inset is not available. > >> Comments? > > What happens when you have a tabular inside a tabular: > > @@ -1963,6 +1963,7 @@ int LyXTabular::TeXRow(ostream & os, row > + OutputParams tmpparams = runparams; > ... > + tmpparams.forceDefaultParagraphs = getPWidth(cell).zero(); > + ret += inset->latex(buf, os, tmpparams); > > shouldn't you have > if (!tmpparams.forceDefaultParagraphs) > tmpparams.forceDefaultParagraphs = getPWidth(cell).zero(); > > ? >
I don't think so. forceDefaultParagraphs is about forcing a default layout to paragraphs inside table cells with no width set (probably a latex restriction): I don't think that this should apply recursively. 1.3.x seems to behave like in the patch. (otoh, the difference is = vs |= so it's no big deal) Alfredo
