Andre Poenitz wrote: > On Sun, Dec 05, 2004 at 08:27:00PM +0100, Alfredo Braunstein wrote: >> This patch solves two crashes with undo, and simplifies a bit undo.cursor >> handling in textUndoOrRedo. > > Whohey. And I just started a fresh checkout on my shining PII/333... > But now that xforms works again it might even fall into the 'usable' > category...
Cool! now we have a developer with even a development machine! That seems an explosive combination ;-) >> One of the crashes is due to copying paragraphs without setting their >> inset_owner to the correct inset. This backpointerage should surely die, >> but until then setting it is certainly needed. >> >> The second one is related to a bad undo.cursor. >> >> I see no evident undo crashes with this patch applied (more testing >> required though). > > Very nice. Commited. > Btw, whenever you feel ill, have quick a look at 1.2.x's undo.C and > enjoy the pleasures of coming back to 1.4 ;-) Don't even mention it, I've only known 1.3.x's undo and I still have nightmares ;-) Regards, Alfredo
