Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| Ok this is my fix to the fitCursor problem in CoordBranch.
>
| I'm posting it here because it changes quite a few things, and I want this
| to get accepted. I'll commit after I receive some comment.
>
| 1) It separates the first and second drawing steps, i.e. takes the metrics
| step out of update to BufferView::Pimpl. To do so I created a
| ViewMetricsInfo struct that holds the needed info to pass between both
| steps: the first and last paragraphs to be painted with their absolute
| positions.
>
| 2) it introduces two new bool parameters to update: fitcursor and
| forceupdate with defaults of true and true respectively.
| fitcursor=true means to fit the cursor and to force an update if position
| changes, forceupdate means to force an update irrespectively. It's not very
| elegant, because the combination false,false doesn't do anything but we can
| change this later.
>
| 3) It moves the decision to greyOut from LyXScreen to BufferView (where it
| belongs IMO)
>
| Comments?
To me this looks very good. But I am not the one knowing this code
most intimately.
| Index: frontends/screen.h
| ===================================================================
| RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/screen.h,v
| retrieving revision 1.29.2.1
| diff -u -p -u -r1.29.2.1 screen.h
| --- frontends/screen.h 3 Nov 2004 22:34:07 -0000 1.29.2.1
| +++ frontends/screen.h 7 Nov 2004 10:51:20 -0000
| @@ -13,10 +13,15 @@
| #ifndef SCREEN_H
| #define SCREEN_H
|
| +#include <support/types.h>
Why is this included here?
--
Lgb
