John Spray <[EMAIL PROTECTED]> writes:

| +namespace frontend {
| +
| +namespace {
| +string defaultUnit("cm");
| +} // namespace anon

Can the default unit change?

If not make it const.

| +     }
| +     //Fallen through, we didn't find the target length!

Space after '//'

| +vector<string> const buildLengthUnitList()
| +{
| +     vector<string> data;
| +     for (int i = 0; i != num_units; ++i)
| +             data.push_back(unit_name_gui[i]);
| +
| +     return data;
| +}

Hmm...

        vector<string> data(unit_name, unit_name + num_units);

should work and is a bit more elegant (and faster.)

-- 
        Lgb

Reply via email to