Angus,

while playing with your mover stuff I got the warning

Unable to sanitize LaTeX "Option": ]

from the external inset. sanitizeLatexOption() was called with the input 
"[,,,]". The last regex was then called with  "]", and this lead to the 
warning message. A possible fix is attached. It does also fix the first 
warning message in sanitizeLatexOption(). Is it ok, or am I fixing 
symptoms here?


Georg
diff -p -r -U 3 -X excl.tmp lyx-1.4-clean/src/insets/ChangeLog lyx-1.4-cvs/src/insets/ChangeLog
--- lyx-1.4-clean/src/insets/ChangeLog	2004-10-23 10:47:30.000000000 +0200
+++ lyx-1.4-cvs/src/insets/ChangeLog	2004-10-24 20:13:37.000000000 +0200
@@ -1,3 +1,8 @@
+2004-10-24  Georg Baum  <[EMAIL PROTECTED]>
+
+	* ExternalTransforms.C (sanitizeLatexOption): fix spurious warning
+	message
+
 2004-10-18  Andreas Vox  <[EMAIL PROTECTED]>
 
 	* insetgraphics.C (docbook, writeImageObject): write more than one
@@ -50,7 +55,7 @@
 2004-09-24  Andreas Vox  <[EMAIL PROTECTED]>
 
 	* insetref.C (docbook): fixing problem where Docbook XML output
-        had unclosed <xref ... >
+	had unclosed <xref ... >
 
 2004-08-16  José Matos  <[EMAIL PROTECTED]>
 
diff -p -r -U 3 -X excl.tmp lyx-1.4-clean/src/insets/ExternalTransforms.C lyx-1.4-cvs/src/insets/ExternalTransforms.C
--- lyx-1.4-clean/src/insets/ExternalTransforms.C	2004-10-11 14:07:02.000000000 +0200
+++ lyx-1.4-cvs/src/insets/ExternalTransforms.C	2004-10-24 20:08:27.000000000 +0200
@@ -281,7 +281,7 @@ string const sanitizeLatexOption(string 
 	regex_match(it, end, what, front, boost::match_partial);
 	if (!what[0].matched) {
 		lyxerr << "Unable to sanitize LaTeX \"Option\": "
-		       << output << '\n';
+		       << input << '\n';
 		return string();
 	}
 	it =  what[1].second;
@@ -304,7 +304,7 @@ string const sanitizeLatexOption(string 
 	// "...foo,,,]" -> "...foo"
 	static boost::regex const back("^(.*[^,])(,*[]] *)$");
 	regex_match(output, what, back);
-	if (!what[0].matched) {
+	if (output != "]" && !what[0].matched) {
 		lyxerr << "Unable to sanitize LaTeX \"Option\": "
 		       << output << '\n';
 		return string();

Reply via email to