Lars Gullik Bjønnes wrote: > | About the patch: > | If you're going to store a shared_ptr in InsetTable, then you might as > | well use it properly: >> > | Index: src/output_latex.C > | - InsetBase * ins = it->inset; > | + InsetBase * ins = it->inset.get(); >> > | Store the local copy as a shared_ptr too. > > Sure. But are we really storing it there? it is a temprary that we > cast to InsetOptArg*.
I don't have the energy to argue one way or the other. Too much exercise is as bad as too litle. -- Angus
