Angus Leeming wrote:
> Brief testing suggests that all is Ok after the change, but I'm
> about to disappear off for a long w/e so don't have time to test
> properly. You might set "table" "table,bottom" in default.ui and
> have a play with the User Guide. Do we get any extra flickering of
> the screen when moving the cursor around?
>
> I'd guess that the same change could also be made to
> XFormsToolbar::show.
JMarc, this patch appears 'sensible'. Maybe it could be the basis for
further testing?
--
Angus
Index: src/frontends/xforms/LayoutEngine.C
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/xforms/LayoutEngine.C,v
retrieving revision 1.2
diff -u -p -r1.2 LayoutEngine.C
--- src/frontends/xforms/LayoutEngine.C 29 Apr 2004 09:54:59 -0000 1.2
+++ src/frontends/xforms/LayoutEngine.C 28 May 2004 11:31:31 -0000
@@ -193,7 +193,7 @@ Box::PreferedVisibility Box::preferedVis
void Box::set(PreferedVisibility pv)
{
prefered_visibility_ = pv;
- if (pv == Invisible)
+ if (pv == Invisible && visible_)
hide();
}
Index: src/frontends/xforms/XFormsToolbar.C
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/xforms/XFormsToolbar.C,v
retrieving revision 1.21
diff -u -p -r1.21 XFormsToolbar.C
--- src/frontends/xforms/XFormsToolbar.C 24 May 2004 11:19:30 -0000 1.21
+++ src/frontends/xforms/XFormsToolbar.C 28 May 2004 11:31:32 -0000
@@ -286,8 +286,8 @@ void C_ToolbarCB(FL_OBJECT * ob, long ac
void XFormsToolbar::hide(bool update_metrics)
{
- if (!toolbar_->visible())
- return;
+// if (!toolbar_->visible())
+// return;
toolbar_->set(Box::Invisible);
if (update_metrics)
@@ -297,8 +297,8 @@ void XFormsToolbar::hide(bool update_met
void XFormsToolbar::show(bool update_metrics)
{
- if (toolbar_->visible())
- return;
+// if (toolbar_->visible())
+// return;
toolbar_->set(Box::Visible);
toolbar_->show();
