Lars Gullik Bjønnes wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
>
> | @@ -610,8 +600,14 @@ pre_connect(int ac, char *av[])
> |
> | for (s = i; s < ac; s++)
> | {
> | - if (load_forms(FALSE, av[s], 0) >= 0)
> | - save_forms(av[s]);
> | + if (load_forms(FALSE, av[s], 0) < 0) {
> | + fprintf(stderr, "Unable to load %s\n", av[s]);
> | + exit(1);
> | + }
> | + if (!save_forms(av[s])) {
> | + fprintf(stderr, "Unable to convert %s\n", av[s]);
> | + exit(1);
> | + }
>
> What if save_forms fails becuase it is unable to create the new
> files? But conversion proper when just ok?
The routine is misnamed. It does both (any necessary) saving and
conversion.
>
> | @@ -780,22 +771,8 @@ main(int ac, char *av[])
> | fd_buttonLabelSize = fl_cntl.buttonFontSize;
> | fl_cntl.buttonFontSize = 0;
> |
> | -
> | /* Initialize stuff */
> | init_classes();
> | -
> | - if (fdopt.conv_only)
> | - {
> | - if (ac == 1)
> | - fprintf(stderr, "%s: -convert requires arguments\n", av[0]);
> | -
> | - for (s = 1; s < ac; s++)
> | - {
> | - load_forms(FALSE, av[s], 0);
> | - save_forms(av[s]);
> | - }
> | - exit(0);
> | - }
>
> Isn't this removing functionality?
No. This code is never reached.
--
Angus
