Jean-Marc Lasgouttes wrote:

> Jean-Marc Lasgouttes wrote:
>> Georg, I would appreciate if you could check the logic of this patch,

I did not test, but the logic complies with my beliefs.

> +string normalize_name(Buffer const * buffer, string const & name,
> +                      string const & ext)
> +{
> +        string const fname = MakeAbsPath(name, buffer->filePath());
> +        if (AbsolutePath(name) || !IsFileReadable(fname + ext))
> +                return name;

Does the IsFileReadable() test only handle the case where a file is found
via kpathsea, or is there another reason for it?

> +        else if (!buffer->niceFile) 
> +                return fname;

Does this mean that the .bib files are found because [EMAIL PROTECTED] is set in
Buffer::makeLaTeXFile()? I think it would be better to be explicit and use
an absolute name then. At least we should change the comment in
Buffer::makeLaTeXFile() (in 1.4).

> +        else 
>
+                return MakeRelPath(fname, buffer->getMasterBuffer()->filePath());
> +}

I don't think that normalize_name() is suitable for more general use in this
form, or are included .tex or graphics files also searched via kpathsea?


Georg

Reply via email to